[gtkada] improvements to the GtkAda build system

Arnaud Charlet charlet at adacore.com
Sat Feb 26 23:12:06 CET 2011


> If that's actually what you want, then I don't want to change it, but I think
> it should be documented better so that users will know what to expect. I have
> changed it back so that the default is "static" except when only shared
> libraries are built, and improved the help text.

Yes, that's what we want: build both by default (if supported), and use static
libs.

Two more general/important comments:

- please provide a changelog for each patch
- only a patch that applies to the svn trunk can be integrated, so better to
  start from the trunk right away

Now for your patch contents:

I do not really like adding the Debuginfo mode which is pretty special cased
for your own need.

I believe the same can be achieved on the command line already: use
--enable-build=Debug at configure time
and then use
make GNATMAKE="gnatmake -O2 -gnatn"

You'll get -g and no strip as you need, and -O2 -gnatn if you want full
optimization, achieving basically the same effect, with no patch.

Can you remind me on which platform/context the GTKADA_LIBS changes are
needed? These changes look OK on principle.

> --- aclocal.m4	2011-02-12 18:23:00.000000000 +0100
> +++ aclocal.m4	2011-02-26 19:09:58.000000000 +0100

OK

> --- src/Makefile.common.in	2011-02-12 18:22:53.000000000 +0100
> +++ src/Makefile.common.in	2011-02-26 19:27:41.000000000 +0100

OK

> --- src/Makefile.in	2011-02-12 18:22:53.000000000 +0100
> +++ src/Makefile.in	2011-02-26 19:36:51.000000000 +0100

OK

> --- aclocal.m4	2011-02-12 18:23:00.000000000 +0100
> +++ aclocal.m4	2011-02-26 19:07:28.000000000 +0100
> @@ -15,11 +15,14 @@
>     AC_ARG_ENABLE(shared,
>       [AC_HELP_STRING(
>          [--disable-shared],
> -        [Disable building of shared libraries])
> +        [Disable building of shared libraries. (The default
> +is to build them if they are supported on the target.)])
>  AC_HELP_STRING(
>          [--enable-shared],
> -        [Build shared libraries if supported on the target
> -Make them the installation default])],
> +        [Build shared libraries if supported on the target.
> +Make them the installation default.
> +(The default installation default is to link to the
> +static libraries when both kinds are built.)])],

'default installation default' is kind of redundant, would be good
to find a better wording.

Arno



More information about the gtkada mailing list