[gtkada] improvements to the GtkAda build system

[Björn Persson]

Arnaud Charlet wrote:
> Apparently you've changed DEFAULT_LIBRARY_TYPE to be shared by default,
> which is not what we want.

I noticed that --enable-shared would enable building shared libraries and set 
DEFAULT_LIBRARY_TYPE to "relocatable", and --disable-shared would disable 
building shared libraries and set DEFAULT_LIBRARY_TYPE to "static", but the 
default was a hybrid behaviour that didn't correspond to either of --enable-
shared and --disable-shared. It seemed like an obvious bug, especially since 
shared libraries is the default in gtkada-config, so I figured I'd fix it.

If that's actually what you want, then I don't want to change it, but I think 
it should be documented better so that users will know what to expect. I have 
changed it back so that the default is "static" except when only shared 
libraries are built, and improved the help text.

> Note that you'r patch contains lots of different changes, some which may
> not be desirable, some which may.
> 
> I would suggest splitting the change into small patches, that will make
> it much easier to review the changes, and to integrate them.
> 
> In particular, the DESTDIR change is mostly mechanical and orthogonal to
> the other changes, so I'd suggest creating a standalone patch for this
> change.
> 
> Same for debuginfo, for --enable-static, etc...

While most of my changes are functionally orthogonal to each other, they 
frequently affect the same lines of code. If I make a separate patch for each 
functional change, then most of the patches will depend on each other and will 
have to be applied in the right order. If you'd reject one, then the later 
ones in the chain would fail.

To avoid having to redo a lot of work, I think I'll submit separate patches 
one at a time and wait for you to review each one before I make the next one.

I'm attaching separate patches for the two changes that aren't entangled with 
the others. These are the Debuginfo build type and linking the sublibraries to 
the main library. I'm also attaching patches for the changes discussed above – 
the --disable-static option and the help text.

Once I know what you think about these patches I'll make the next one. If 
you'd like to review them in some particular order, let me know.

Björn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GtkAda-trunk-debuginfo.patch
Type: text/x-patch
Size: 2006 bytes
Desc: not available
Url : /pipermail/gtkada/attachments/20110226/2ffa8fd4/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GtkAda-trunk-linking.patch
Type: text/x-patch
Size: 1566 bytes
Desc: not available
Url : /pipermail/gtkada/attachments/20110226/2ffa8fd4/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GtkAda-trunk-disable-static.patch
Type: text/x-patch
Size: 4402 bytes
Desc: not available
Url : /pipermail/gtkada/attachments/20110226/2ffa8fd4/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GtkAda-trunk-help.patch
Type: text/x-patch
Size: 830 bytes
Desc: not available
Url : /pipermail/gtkada/attachments/20110226/2ffa8fd4/attachment-0003.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
Url : /pipermail/gtkada/attachments/20110226/2ffa8fd4/attachment.pgp