[gtkada] [Fwd: patches: missing shared-libgcc + DESTDIR support]

[Björn Persson]

John Marino wrote:
> On 2/4/2011 9:04 AM, Arnaud Charlet wrote:
> >>              $(MAKE) -C glade install; \
> >>              $(MAKE) -C gnome install; \
> >>              $(MAKE) -C tools install; \
> >> -	   $(CHMOD) ugo-w $(alidir)/static/*.ali; \
> >> -	   if [ $(BUILD_SHARED) = yes ]; then \
> >> -	      $(CHMOD) ugo-w $(alidir)/relocatable/*.ali; \
> >> -	   fi; \
> >>   	fi
> > 
> > The above hunk on src/Makefile.in looks wrong/unjustified though, can you
> > clarify?
> 
> I heard back from Matthias on this:
> 
> "Hmm - yes, this one is unnecessary. chown, and chmod if it sets
> setuid or so, can cause problems for installs by non-privileged
> users, so I've just removed the lines. See that it only removes
> write permissions -- I think is unnecessary to do in general,
> that's what the umask is for. But this is Adacore's choice."
> 
> So that was the logic for removing those lines.

Obviously Matthias doesn't know that write-protecting ALI files is the way to 
instruct Gnatmake not to recompile the library.

Björn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
Url : /pipermail/gtkada/attachments/20110207/c2e70852/attachment.pgp