[gtkada] DESTDIR blocked, patch provided

[John Marino]

On 7/1/2013 14:25, Emmanuel Briot wrote:
>> DESTDIR=
>
> No, the latter is correct as per GNU make documentation.

Hmmm.  What seems to be happening is that DESTDIR is defined by command 
line and then immediately overridden by the Makefile (which is behavior 
I'm used to).  I'm just not seeing the behavior described in section 9.5.

> Note the last paragraph which is exactly what we are doing, and thus if you
> specify a value on the command line the default value set in the Makefile
> is ignored (or should be, if for some reason it isn't in your case). Specifying the
> value on the command line is of course the intended use, again as per Make
> documentation.
> However, that documentation also contains the following paragraph which goes
> towards what you are saying:
>     You should not set the value of `DESTDIR' in your `Makefile' at all;
> then the files are installed into their expected locations by default.
> Also, specifying `DESTDIR' should not change the operation of the
> software in any way, so its value should not be included in any file
> contents.

Ah, maybe DESTDIR is a very special case that's handled differently that 
9.5 states.

> So I believe GtkAda is currently correct, although indeed applying your patch
> might be more in line with the recommended approach.
> I will therefore apply the patch.

I certainly appreciate that!
I'm trying to get 2.24.4 into FreeBSD ports now and trying to figure out 
why DESTDIR malfunctioned took a while.

Regards,
John