[gtkada] Darwin static library patch

[Chris Douty]

On Tuesday, July 27, 2004, at 04:11 PM, Arnaud Charlet wrote:

>> OK, after enough complaining here is a patch.
>
> Thanks. Here are my comments:
>
> +   TARGET_LFLAGS=-bind_at_load
>
> Clearly, this needs to be done in the darwin specific section, not
> for every platform. It would be good to know whether this is really
> needed or not, and get rid of it if possible.

Oops.  I did intend for that to go into the darwin section.  I doubt 
that the AIX linker, for example, would be amused.  I guess that's what 
I get for hacking makefiles at 2 AM. :-)

[snip]

> @@ -161,6 +165,13 @@
>      GTK_PREFIX=`$PKG_CONFIG $GTK --variable=prefix`
>      GTK_CFLAGS=`$PKG_CONFIG $GTK --cflags`
>      GTK_LIBS=`$PKG_CONFIG $GTK --libs`
> +dnl The XWarpPointer function introduced in misc.c requires a direct 
> libX11
> +dnl reference on darwin.
> +    case  $build_os in
> +    *darwin*)
> +       GTK_LIBS="$GTK_LIBS -L/usr/X11R6/lib -lX11"
> +       ;;
>
> Hmm I guess that's OK for now. I'll see whether I can figure out a 
> cleaner
> way to do that.

In the light of day, a "cleaner" way might be to create an EXTRA_LIBS 
variable that contains the additions.  Of course it would need to 
propagate to every Makefile and gtkada-config program too.  Essentially 
those linker flags are required for building an executable with 
libgtkada.a.  An unintended side-effect is that configure found OpenGL 
without further prodding.  It would be nice if it worked, but it did 
find the right libraries.

An EXTRA_LIBS solution might be more flexible, but it is certainly more 
invasive.

Cheers,
	Chris

-- 
Christopher Douty <Chris_Douty at ampexdata.com> +1-650-367-3129
Senior Engineer, Software & Systems  - AMPEX Data Systems Corp.