[AWS] [PATCH] Added support for sending emails where the source has already been composed. (second try)

Pascal Obry pascal at obry.net
Wed Feb 9 09:44:25 CET 2011


Hello Thomas,

> I've tried to create a new patch file for you. I hope this one is
> better than the previous one.

Style is fine. I would refactor the code in Output_Header and
Output_Simple_Header. Looking at both routines it seems that
Output_Header could call Output_Header and then continue sending the
remaining data. This would avoid duplicating code.

> I'm not exactly an eagle at using Git for collaboration, as I've
> mostly used it for my own solo projects.

No problem. If you don't have an MTA working on your machine you cannot
use git-send-email, but can you send patch inlined into the message?

In this case I can use git-am directly on my mailbox to integrate the
sent patches. Note that in this case the e-mail subject is the first
line of the changelog. So it must contains only text to be committed
(the [AWS] [PATCH] are cleaned-up, so that's not a problem).

> But I'm learning! Ever so slowly...  :D

Fine :) Do not hesitate to ask if something is not clear.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B



More information about the AWS mailing list